Merge feature/hardening into develop #11

Merged

admin merged 2 commits from feature/hardening into develop 2026-03-01 02:57:25 +00:00

Conversation 0 Commits 2 Files Changed 3

+402 -106

2 Commits

Author	SHA1	Message	Date
t3hn3rd	2239d9c848	Rebase: Fixed console -> syslog interface	2026-03-01 02:46:13 +00:00
t3hn3rd	beb4b253ab	fix: guard against uint32 underflow in memset/memcpy and strings unit ... When size=0 was passed to memset() or memcpy(), the loop bound `0 to size-1` underflowed to $FFFFFFFF, iterating ~4 billion times and causing an immediate page fault. Added `if size = 0 then exit` guards to both memset() and memcpy() in util.pas. Also guarded all `for i:=0 to X-1` loops in strings.pas where X could be 0 on empty string inputs: - stringToUpper: wrap loop in `if stringSize > 0` - stringToLower: wrap loop in `if stringSize > 0` - stringEquals: early exit when both sizes are 0 - stringToInt: early exit when string is empty Additionally fixed all previously identified bugs in strings.pas: - hexStringToInt: guard against empty string underflow - stringConcat: cache stringSize calls to avoid redundant O(n) scans - stringTrim: clamp length to source string size - stringSub: bounds check start/size against source length - stringReplace: complete rewrite - was using stringEquals() for substring matching (only matched at string end), dropped prefix chars, had dangling assignment overwriting valid result with uninitialized pointer, and had unused variable - stringIndexOf: rewritten to use new stringMatchAt() helper for correct substring matching - stringContains: simplified to delegate to fixed stringIndexOf(), also fixing uint32 underflow when sub was empty - stringToInt: removed always-true `v >= 0` check on uint32 - intToString: implemented (was a stub returning ' ') - Added stringMatchAt() helper for prefix comparison - Added comprehensive UnitTest procedure with 77 assertions including adversarial empty/nil/boundary inputs	2026-03-01 02:33:28 +00:00