Fixed a DHCP bug #5

2025-03-17T00:04:14Z

t3hn3rd commented

2025-03-17 00:04:14 +00:00

Fixed a bug within dhcp.pas - processPacket_OFFER in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter.
Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0]).
Allowed processPacket_OFFER to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).

- Fixed a bug within `dhcp.pas` - `processPacket_OFFER` in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter. - Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling `copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0])`. - Allowed `processPacket_OFFER` to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).

t3hn3rd added 1 commit 2025-03-17 00:04:15 +00:00

Fixed a DHCP bug

continuous-integration/drone/pr Build is passing

Details

continuous-integration/drone/push Build is passing

Details

48c203f028

- Fixed a bug within `dhcp.pas` - `processPacket_OFFER` in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter.
- Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling `copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0])`.
- Allowed `processPacket_OFFER` to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).

t3hn3rd requested review from Aaron 2025-03-21 19:24:02 +00:00

t3hn3rd scheduled this pull request to auto merge when all checks succeed 2025-03-21 20:27:50 +00:00

Aaron approved these changes

2025-03-22 19:13:22 +00:00

t3hn3rd merged commit b1e3953960 into develop

2025-03-22 19:13:26 +00:00

t3hn3rd referenced this issue from a commit

2025-03-22 19:13:27 +00:00

Merge pull request 'Fixed a DHCP bug' (#5) from feature/DHCP-BugFix into develop

Sign in to join this conversation.