Spexeah/Asuro
Spexeah/Asuro
3
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixed a DHCP bug #5

Merged
t3hn3rd merged 1 commits from feature/DHCP-BugFix into develop 2025-03-22 19:13:26 +00:00
Conversation 1 Commits 1 Files Changed 1 +14 -6
t3hn3rd commented 2025-03-17 00:04:14 +00:00
Owner
Copy Link
  • Fixed a bug within dhcp.pas - processPacket_OFFER in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter.
  • Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0]).
  • Allowed processPacket_OFFER to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).
- Fixed a bug within `dhcp.pas` - `processPacket_OFFER` in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter. - Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling `copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0])`. - Allowed `processPacket_OFFER` to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).
t3hn3rd added 1 commit 2025-03-17 00:04:15 +00:00
Fixed a DHCP bug
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
48c203f028 
- Fixed a bug within `dhcp.pas` - `processPacket_OFFER` in which the client was responding with the client IP value within the DHCP header was incorrectly being filled out with the IP being requested & this value was then being used within the REQUESTED_IP_ADDRESS option. Corrected this to fill out the client IP with the currently configured IP, which will be NULL (0.0.0.0) on boot, and whatever is issued thereafter.
- Cascaded the change to use the currently configured IP as opposed to a NULL IP to any other functions that were calling `copyIPv4(@NULL_IP[0], @packetCtx^.IP.Source[0])`.
- Allowed `processPacket_OFFER` to process packets addressed to the BROADCAST MAC (WHY COULDN'T IT DO THIS ALREADY?!).
t3hn3rd requested review from Aaron 2025-03-21 19:24:02 +00:00
t3hn3rd scheduled this pull request to auto merge when all checks succeed 2025-03-21 20:27:50 +00:00
Aaron approved these changes 2025-03-22 19:13:22 +00:00
t3hn3rd merged commit b1e3953960 into develop 2025-03-22 19:13:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Aaron
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Aaron admin t3hn3rd
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Spexeah/Asuro#5
No description provided.
Delete Branch "feature/DHCP-BugFix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?